Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add Health to FVT pipeline #303

Merged
merged 1 commit into from
May 24, 2023
Merged

[minor] Add Health to FVT pipeline #303

merged 1 commit into from
May 24, 2023

Conversation

karlinglee93
Copy link
Contributor

@karlinglee93 karlinglee93 commented May 17, 2023

add configurations in fvt.yml and create health.yml file for the new health pipeline repos to fvt pipeline.

Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karlinglee93 Can you add a description into the first section of this PR of what this PR adds, and update the title to be more descriptive, thanks.

@karlinglee93 karlinglee93 changed the title [patch] add health [patch] add configurations of health pipeline repos to cli May 18, 2023
@karlinglee93
Copy link
Contributor Author

@karlinglee93 Can you add a description into the first section of this PR of what this PR adds, and update the title to be more descriptive, thanks.

Hi @whitfiea , please check.

@whitfiea whitfiea self-requested a review May 18, 2023 11:15
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. @alequint are you happy for this to be merged?

Copy link
Contributor

@durera durera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates new task definitions for Health FVT, but doesn't seem to add them into the FVT pipeline, is there a commit missing here that wasn't checked in perhaps?

@durera durera changed the title [patch] add configurations of health pipeline repos to cli [minor] Add Health to FVT pipeline May 18, 2023
@durera durera merged commit 78ad1c8 into master May 24, 2023
@durera durera deleted the add-health branch May 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants