[patch] Fix must-gather useability issues #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
mas must-gather
and no Suite instance is found there will be an error message printed:This is misleading and gives the impression must-gather failed; it's just we are not capturing the err from looking up whether there are any MAS instances to collect gather from. In the case there is no MAS instance, we still want to collect the must-gather and we don't want to give the impression there was an error generating it.
An additional confirmation the must-gather was generated is also now provided:

mas must-gather --help
is also now implemented: