Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Improve uninstall pipeline #182

Merged
merged 17 commits into from
Feb 17, 2023
Merged

[patch] Improve uninstall pipeline #182

merged 17 commits into from
Feb 17, 2023

Conversation

rawa-resul
Copy link
Contributor

@rawa-resul rawa-resul commented Feb 15, 2023

Details

  • Discussion here
  • Uninstall PipelineRun now uses individual tasks rather than the uninstall_core playbook
  • Added default "" to required params in SLS task
  • Leverage existing Tasks and add the *_ACTION param/env var
  • Make workspaces optional in sls, uds and mongo tasks so that we don't need to pass it in during uninstall
  • Added dependency flow when prompting for uninstalling mas dependencies
  • General cleanup and formatting fixes

PipelineRun

Screenshot 2023-02-15 at 2 28 32 am

Testing

  • Ran uninstall path with various combinations

@rawa-resul rawa-resul self-assigned this Feb 15, 2023
@rawa-resul rawa-resul marked this pull request as ready for review February 15, 2023 02:33
@rawa-resul rawa-resul requested a review from durera as a code owner February 15, 2023 02:33
@durera durera changed the title [patch] Improve Uninstall Path [patch] Improve uninstall pipeline Feb 17, 2023
@durera durera merged commit fa62623 into master Feb 17, 2023
@durera durera deleted the uninstall-improvement branch February 17, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants