Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Run watsonstudio cfg even if cp4d not installed locally for gitops #1467

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

whitfiea
Copy link
Contributor

@whitfiea whitfiea commented Feb 13, 2025

Removes the requirement in the gitops pipeline that the cp4d wsl service is installed on the same cluster. This will allow the watsonstudio config to be set for cp4d that is either oncluster or offcluster.

when offcluster then the following secrets should be set in SecretsManager:

WATSON_STUDIO_SECRET=${ACCOUNT_ID}${SECRETS_KEY_SEPERATOR}${CLUSTER_ID}${SECRETS_KEY_SEPERATOR}${MAS_INSTANCE_ID}${SECRETS_KEY_SEPERATOR}wsl-cp4d

SECRET_KEY_WATSON_STUDIO_USERNAME=${WATSON_STUDIO_SECRET}#username
SECRET_KEY_WATSON_STUDIO_PASSWORD=${WATSON_STUDIO_SECRET}#password
SECRET_KEY_WATSON_STUDIO_URL=${WATSON_STUDIO_SECRET}#url

Also removes the mas_config_scope as this is actually being set as system within the task, and predict is deployed to use system scope

Adds in gitops-delete-jdbc-config-iot that was missing when IoT is removed.

@whitfiea whitfiea changed the title [patch] Run watsonstudiop cfg even if cp4d not installed locally [patch] Run watsonstudio cfg even if cp4d not installed locally for gitops Feb 25, 2025
@whitfiea whitfiea marked this pull request as ready for review February 25, 2025 14:35
@maulik-modi22
Copy link

Can you check if it supports CA cert to have an additional layer of security?

@whitfiea
Copy link
Contributor Author

@maulik-modi22 there is no validation for Watson studio cfg in MAS Core. For Predict I don't know if server certificates are verified or not, I don't see an option to set it.

@whitfiea whitfiea merged commit 42d478a into master Feb 26, 2025
12 checks passed
@whitfiea whitfiea deleted the ajw-cp4dexternal branch February 26, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants