[patch] sls_mongodb_cfg_file for custom mongodb namespace #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 7, 2025 19:30
sarthakSharma5
changed the title
sarthakSharma5
requested review from
durera,
JonahLuckett,
andrercm,
sanjayprab,
terenceq,
whitfiea,
alequint and
leo-miran
as code owners
rawa-resul
requested changes
Feb 5, 2025
rawa-resul
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for sls_mongodb_cfg_file path
Fixes a bug which causes install failure in SLS stage when using non-interactive method and a custom MongoDB namespace is provided in parameters.
Sets the parameter
sls_mongodb_cfg_fileto/workspace/configs/mongo-{mongodb_namespace}.ymlIssue
By default, MAS installation fails when using the non-interactive method and opting for a custom MongoDB namespace.
This happens because the value for the parameter
sls_mongodb_cfg_fileremains at default, which is then used by the mas_devops.sls role and causes a failure since the config file is not present at the path provided (which defaults to/workspace/configs/mongo-mongoce.yml).To Replicate use
--mongodb-namespace "mongoce-$MAS_INSTANCE_ID"with the non-interactive install command.Before Fix (failing SLS task during install)
After Fix (with successful FVT run)
- SLS task run
- FVT Runs for a MAS Installation (with IoT)