Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Added HMAC to COS role #1215

Merged
merged 16 commits into from
Aug 30, 2024
Merged

[minor] Added HMAC to COS role #1215

merged 16 commits into from
Aug 30, 2024

Conversation

Vishal-patel-7
Copy link
Contributor

@Vishal-patel-7 Vishal-patel-7 commented Aug 28, 2024

As a part of https://jsw.ibm.com/browse/MAXMF-455 we added new environment variable USE_HMAC to create COS with HMAC support. There is PR ibm-mas/ansible-devops#1407 in ansible-devops regarding this.

@chiragcsatani chiragcsatani marked this pull request as ready for review August 28, 2024 10:55
Copy link
Contributor

@whitfiea whitfiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ansible-devops role now allows the config scope to be set and the use_hmac to be set, which is all fine. But that means that for an env that has assist, mvi and manage installed we need the following set:

  • objectstorage-cfg at system scope with use_hmac as false
  • objectstorage-cfg at app/workspace(for manage) scope with use_hmac as true

I don't think the changes here allow the scope to be set or for more than one config/dependency to be created

@Vishal-patel-7
Copy link
Contributor Author

The ansible-devops role now allows the config scope to be set and the use_hmac to be set, which is all fine. But that means that for an env that has assist, mvi and manage installed we need the following set:

  • objectstorage-cfg at system scope with use_hmac as false
  • objectstorage-cfg at app/workspace(for manage) scope with use_hmac as true

I don't think the changes here allow the scope to be set or for more than one config/dependency to be created

I don't know how to handle this but the aim for the changes are to give new environment variable support for ansible-devops role. @chiragcsatani can you confirm what we need to do ? This is to fix fvt issue for manage but for assist & mvi we may have to revisit this code and ansible-devops role also.

@whitfiea whitfiea self-requested a review August 30, 2024 07:59
@whitfiea whitfiea changed the title [patch] MASCORE-3383 Added HMAC to COS role [minor] Added HMAC to COS role Aug 30, 2024
@whitfiea whitfiea merged commit cee68b0 into master Aug 30, 2024
8 checks passed
@whitfiea whitfiea deleted the MASCORE-3383-1 branch August 30, 2024 08:10
durera added a commit that referenced this pull request Aug 31, 2024
@Vishal-patel-7 Vishal-patel-7 restored the MASCORE-3383-1 branch September 2, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants