Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Remove MIF Tests From FVT Pipeline #1131

Merged
merged 10 commits into from
Aug 9, 2024
Merged

[patch] Remove MIF Tests From FVT Pipeline #1131

merged 10 commits into from
Aug 9, 2024

Conversation

chiragcsatani
Copy link
Contributor

base-ui-mif-setup

base-ui-mif-kafka-setup

base-ui-mif-jms-inbound

base-ui-mif-kafka-inbound

Above tests are actively being converted to pytest. Hence removing from pipeline

base-ui-mif-setup

base-ui-mif-kafka-setup

base-ui-mif-jms-inbound

base-ui-mif-kafka-inbound

Above tests are actively being converted to pytest. Hence removing from pipeline
@chiragcsatani chiragcsatani requested a review from alequint July 22, 2024 19:45
@chiragcsatani chiragcsatani changed the title MASISMIG-56632- Remove Tests MASISMIG-56632- Remove MIF Tests From Pipeline Jul 22, 2024
@alequint alequint changed the title MASISMIG-56632- Remove MIF Tests From Pipeline [patch] MASISMIG-56632- Remove MIF Tests From Pipeline Jul 22, 2024
@alequint
Copy link
Contributor

alequint commented Jul 22, 2024

Your changes look good @chiragcsatani but we need to have some test evidence here to see how pipeline looks like after this change. What you can do for a quick review:

  • oc login your internal fyre cluster
  • in cli/tekton, run the two playbooks there:
ansible-playbook generate-tekton-pipelines.yml
ansible-playbook generate-tekton-tasks.yml
  • in cli/tekton, run test.sh - it will connect in the cluster you logged in above, and will install all the resources created by playbooks above (they will be all created in cli/tekton/target) and install them in the default namespace of your cluster (which will not affect the pipelines, which run in thei own mas-xxx-pipelines namespace).

  • Run it till the end and post evidence in the PR. Also, go to your cluster look for fvt-manage pipeline inside the default namespace to check if phases are preserved and if no error was introduced. Paste screenshot as evidence in this PR.

By doing this, creating the resources in the cluster without problem it means you will not have problems during setup_pipeline task in ansible-fvt. Otherwise it might block all the official pipelines to run

Copy link
Contributor

@alequint alequint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test evidence requested: #1131 (comment)

@durera durera changed the title [patch] MASISMIG-56632- Remove MIF Tests From Pipeline [patch] Remove MIF Tests From FVT Pipeline Jul 25, 2024
@unnati-solanki-git
Copy link
Contributor

@chiragcsatani @alequint I attempted to run this locally as mentioned in the instruction and able to see the sequence of task/test like this:

image

Let me know if you need anything else. Thanks!

@chiragcsatani chiragcsatani requested a review from alequint August 7, 2024 06:28
@chiragcsatani
Copy link
Contributor Author

@alequint can you provide your feedback here @unnati-solanki-git
if its okay then we can merge so jira item can be closed.

@alequint
Copy link
Contributor

alequint commented Aug 9, 2024

Sequence of tasks look great... thanks for posting @unnati-solanki-git (and sorry, did not see it before, not following Git emails, relying on Slack notification to review the PRs 😄 )

@alequint alequint merged commit 75d61eb into master Aug 9, 2024
8 checks passed
@alequint alequint deleted the MASISMIG-56632 branch August 9, 2024 21:15
andrefgj pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Chirag Satani <[email protected]>
Co-authored-by: Alexandre Quinteiro <[email protected]>
Co-authored-by: unnati-solanki-git <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants