-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] Remove MIF Tests From FVT Pipeline #1131
Conversation
base-ui-mif-setup base-ui-mif-kafka-setup base-ui-mif-jms-inbound base-ui-mif-kafka-inbound Above tests are actively being converted to pytest. Hence removing from pipeline
Your changes look good @chiragcsatani but we need to have some test evidence here to see how pipeline looks like after this change. What you can do for a quick review:
By doing this, creating the resources in the cluster without problem it means you will not have problems during setup_pipeline task in ansible-fvt. Otherwise it might block all the official pipelines to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test evidence requested: #1131 (comment)
@chiragcsatani @alequint I attempted to run this locally as mentioned in the instruction and able to see the sequence of task/test like this: ![]() Let me know if you need anything else. Thanks! |
@alequint can you provide your feedback here @unnati-solanki-git |
Sequence of tasks look great... thanks for posting @unnati-solanki-git (and sorry, did not see it before, not following Git emails, relying on Slack notification to review the PRs 😄 ) |
Co-authored-by: Chirag Satani <[email protected]> Co-authored-by: Alexandre Quinteiro <[email protected]> Co-authored-by: unnati-solanki-git <[email protected]>
base-ui-mif-setup
base-ui-mif-kafka-setup
base-ui-mif-jms-inbound
base-ui-mif-kafka-inbound
Above tests are actively being converted to pytest. Hence removing from pipeline