[patch] Fix catalog validation in dev mode #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopauloksn
requested review from
durera,
andrercm,
sanjayprab,
terenceq,
whitfiea,
alequint and
leo-miran
as code owners
durera
changed the title
durera
approved these changes
Jul 4, 2024
andrefgj
pushed a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Joao Paulo Karol Nunes <[email protected]> Co-authored-by: David Parker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing catalogVersion and catalogImage vars as they were not being used.
Catalog validation in based on the assumption the displayName will follow a given pattern.
We have two different scenarios we want to cover:
1- When dev mode is set, we need to skip this validation;
1.1- Interactive mode:
DEV_MODE comes from env var (string)
1.2- Non interactive mode:
DEV_MODE comes from args (boolean)
2- When the displayName does not match what is expected, we abort the installation and ask the admin to update the catalog first.
When dev mode is not set and catalog displayName is wrong:
When dev mode is set or catalog displayName is correct:
