Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Fix Assist on 8.x logic #1080

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[patch] Fix Assist on 8.x logic #1080

merged 1 commit into from
Jul 2, 2024

Conversation

durera
Copy link
Contributor

@durera durera commented Jul 2, 2024

We added code to stop presenting the option to install Assist in 8.x, but did not initialise installAssist = False, resulting in the following:

Traceback (most recent call last):
  File "/opt/app-root/bin/mas-install", line 964, in <module>
    app.install(args)
  File "/opt/app-root/bin/mas-install", line 881, in install
    self.interactiveMode()
  File "/opt/app-root/bin/mas-install", line 536, in interactiveMode
    self.assistSettings()
  File "/opt/app-root/bin/mas-install", line 497, in assistSettings
    if self.installAssist:
AttributeError: 'App' object has no attribute 'installAssist'

We added code to stop presenting the option to install Assist in 8.x, but did not initialise installAssist = False
@durera durera added the Bug Fix label Jul 2, 2024
@durera durera merged commit e1a506c into master Jul 2, 2024
3 checks passed
@durera durera deleted the assistfix branch July 2, 2024 09:16
@durera durera restored the assistfix branch July 4, 2024 11:48
@durera durera deleted the assistfix branch July 4, 2024 11:48
andrefgj pushed a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant