[patch] Support Db2 resource customization #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durera
requested changes
Dec 6, 2022
durera
changed the title
alequint
requested changes
Dec 13, 2022
alequint
approved these changes
Dec 14, 2022
|
Looks good to me, all the requested changes have been addressed and tests have been performed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for code changes made for Single Node OpenShift.
Tested on bare metal env. Installed LVM storage class and used this code to install MAS and Manage.
https://console-openshift-console.apps.sno4.sarika.donatelli.click/k8s/ns/mas-sno-pipelines/tekton.dev~v1beta1~PipelineRun/sno-install-mtz5p
xZZEm-UDni9-txrYM-f6L7A