Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] mobile-version-finder fix #1057

Merged
merged 5 commits into from
Jun 25, 2024
Merged

[patch] mobile-version-finder fix #1057

merged 5 commits into from
Jun 25, 2024

Conversation

leo-miran
Copy link
Contributor

@leo-miran leo-miran commented Jun 25, 2024 •
edited
Loading

  • Fix issue for situation where graphite app zip file does not contain a build.json file.
  • fvt-mobile-pytest task env var (UPLOAD_FILE) defaults to "" (None) so file upload is properly skipped.
  • Adds instance_name and build_num to file version name
    Version file example after these updates:
    ivt811x-1234-mobile-is-versions.json

@leo-miran leo-miran marked this pull request as ready for review June 25, 2024 17:45
@alequint alequint merged commit e92def0 into master Jun 25, 2024
3 checks passed
@alequint alequint deleted the mobver-fix branch June 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alequint alequint alequint approved these changes

@durera durera Awaiting requested review from durera durera is a code owner

@andrercm andrercm Awaiting requested review from andrercm andrercm is a code owner

@sanjayprab sanjayprab Awaiting requested review from sanjayprab sanjayprab is a code owner

@terenceq terenceq Awaiting requested review from terenceq terenceq is a code owner

@whitfiea whitfiea Awaiting requested review from whitfiea whitfiea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-miran @alequint