Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Roles still publish secrets to stdout #973

Closed
kumareshsun opened this issue Aug 21, 2023 · 2 comments
Closed

Multi Roles still publish secrets to stdout #973

kumareshsun opened this issue Aug 21, 2023 · 2 comments
Assignees
Labels
Bug Report Something isn't working

Comments

@kumareshsun
Copy link

Hi @andrercm

Tested the latest version of the collection following the Merge of #955 to the main branch.
I noticed the stdout still contains secrets for some tasks, but it looks like a good improvement from where it was before!

Let me list the ones that I'm working on:-

TASK [ibm.mas_devops.mongodb : community : install : Create MAS MongoCfg (debug)]
This task displays the Username and password details of Mongo Admin Configuration

TASK [ibm.mas_devops.install_operator : Debug Entitlement Secret Creation]

This task displays the entitlement password.

@andrercm
Copy link
Contributor

I'll remove Create MAS MongoCfg (debug) step

as to the Debug Entitlement Secret Creation, in the first pull request, I've already masked the passwords if they are set, and it not defined, then we'll display <undefined>

- name: "Debug Entitlement Secret Creation"
  debug:
    msg:
      - "Target Namespace ....................... {{ namespace }}"
      - "Artifactory Username ................... {{ artifactory_username | default('<undefined>', true) }}"
      - "Artifactory Password ................... {{ '************' if (artifactory_token is defined) else '<undefined>' }}"
      - "ICR Username ........................... {{ icr_username | default('<undefined>', true) }}"
      - "ICR Password ........................... {{ '************' if (icr_password is defined) else '<undefined>' }}"

@andrercm
Copy link
Contributor

Fixed with the associated PR #972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants