Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deliteful/list/PageableList is crashing IE10 #280

Closed
sbrunot opened this issue Sep 11, 2014 · 5 comments
Closed

deliteful/list/PageableList is crashing IE10 #280

sbrunot opened this issue Sep 11, 2014 · 5 comments
Assignees
Milestone

Comments

@sbrunot
Copy link
Member

sbrunot commented Sep 11, 2014

When trying to load a new page of data in a PageableList on IE10, the browser crash (displays an error message in a popup).

This is due to the following issue on dstore 0.2.0: dojo/dojo1-dstore#49

One consequence of this issue is that the PageableList functional tests never ends on IE10, failing the Travis CI build with no apparent reason.

@sbrunot sbrunot self-assigned this Sep 11, 2014
@sbrunot sbrunot modified the milestones: 0.3.0, 0.4.0 Sep 11, 2014
@sbrunot
Copy link
Member Author

sbrunot commented Sep 16, 2014

Not reproduced after upgrading IE10 to version 10.0.9200.17089. I need to investigate how to setup the SauceLabs tests so that they run in a recent version of IE10 (current version of IE10 on SauceLabs is 10.0.9200.16686).

@cjolif
Copy link
Contributor

cjolif commented Dec 5, 2014

So it seems it is just a matter of testing it and re-enabling tests. @tkrugg can you look into this?

@cjolif
Copy link
Contributor

cjolif commented Dec 5, 2014

And when/if that is fixed don't forget to remove the "non supported" warning on IE10 from the doc.

@cjolif cjolif closed this as completed in aec11b9 Dec 10, 2014
@edchat
Copy link
Contributor

edchat commented Dec 17, 2014

I think this change is causing hangs in the internet explorer 10 on WINDOWS tests.
I know it is causing a hang for me in my latest updates for the skip() support, (it is easier to tell with the customRunner reporter because it shows the tests in tests/unit/list/PageableList.js being started for IE10, but then they do not continue). I suspect it also broke the travis build because it worked before this change, and it has not since, and when I looked in the log I did not see internet explorer 10 on WINDOWS completed. See https://travis-ci.org/ibm-js/deliteful/builds for the build history.

@edchat edchat reopened this Dec 17, 2014
@tkrugg
Copy link
Member

tkrugg commented Dec 18, 2014

As far as I could find, you can't get saucelab to execute your code under a specific build of ie10. But 10.0.9200.17089 (the version @sbrunot says works) happens to be available when requesting ie10 under windows 7, as you can see it in the list of environments they support. I'll try it and get back to you.

edchat added a commit to edchat/deliteful that referenced this issue Dec 18, 2014
@cjolif cjolif modified the milestones: 0.7.0, 0.6.0 Jan 14, 2015
cjolif pushed a commit to cjolif/deliteful that referenced this issue Feb 5, 2015
@cjolif cjolif closed this as completed in d6f0100 Feb 6, 2015
edchat added a commit that referenced this issue Feb 6, 2015
wkeese pushed a commit to wkeese/deliteful that referenced this issue Mar 12, 2015
wkeese pushed a commit to wkeese/deliteful that referenced this issue Mar 12, 2015
wkeese pushed a commit to wkeese/deliteful that referenced this issue Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants