Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Widget#deliver() automatically on creation #385

Closed
wkeese opened this issue Mar 19, 2015 · 0 comments
Closed

Call Widget#deliver() automatically on creation #385

wkeese opened this issue Mar 19, 2015 · 0 comments
Assignees
Milestone

Comments

@wkeese
Copy link
Member

wkeese commented Mar 19, 2015

Call Widget#deliver() when widgets created programatically, or declaratively via the parser. Replaces ibm-js/decor#8, see that ticket for lengthy discussion.

@wkeese wkeese added this to the 0.7.0 milestone Mar 19, 2015
wkeese added a commit to wkeese/delite that referenced this issue Mar 19, 2015
…declaratively.

Avoids widgets having a stale state (i.e. DOM nodes not updated or computed properties
not computed) when applications access the widget immediately after it has been created,
before the widget is updated automatically due to the timer firing.

Note that when created programatically, deliver() will be called even if the widget
isn't yet attached to the DOM.

Fixes ibm-js#385.
wkeese added a commit to wkeese/delite that referenced this issue Mar 19, 2015
…declaratively.

Avoids widgets having a stale state (i.e. DOM nodes not updated or computed properties
not computed) when applications access the widget immediately after it has been created,
before the widget is updated automatically due to the timer firing.

Note that when created programatically, deliver() will be called even if the widget
isn't yet attached to the DOM.

Fixes ibm-js#385.
wkeese added a commit to wkeese/delite that referenced this issue Mar 19, 2015
Runs both for programatically and declarative widgets, after the user-specified parameters
have been applied.  Note that when widgets are created programatically, deliver() will
be called even if the widget isn't yet attached to the DOM.

Avoids widgets having a stale state (i.e. DOM nodes not updated or computed properties
not computed) when applications access the widget immediately after it has been created,
before the widget is updated automatically due to the timer firing.

Fixes ibm-js#385.
@wkeese wkeese self-assigned this Mar 19, 2015
@wkeese wkeese changed the title call deliver() automatically on Widget creation Call Widget#deliver() automatically on creation Mar 19, 2015
@wkeese wkeese closed this as completed in b3638c5 Mar 19, 2015
wkeese added a commit to ibm-js/deliteful that referenced this issue Mar 20, 2015
wkeese added a commit to ibm-js/deliteful that referenced this issue Mar 20, 2015
The element is not necessarily attached to the DOM when refreshRendering() runs.
This bug caused test failures in tests/unit/SidePane.js.
Refs ibm-js/delite#385.
wkeese added a commit to ibm-js/deliteful that referenced this issue Mar 20, 2015
Updating value is async, even if you call deliver(), since the change is detected via
a MutationObserver.
Refs ibm-js/delite#385.
wkeese added a commit that referenced this issue Mar 20, 2015
wkeese added a commit that referenced this issue Mar 27, 2015
This is more efficient for programatically created widgets because it avoids
calling computeProperties() and refreshRendering() twice on initialization:
once with the default property values and once after user specified values have
been processed.

Refs #385, works around ibm-js/deliteful#535 and therefore fixes ibm-js/deliteful#532.
wkeese added a commit that referenced this issue Apr 1, 2015
… advice,

so that it processes changes made by subclasses' attachedCallback() methods.

Refs #385, refs ibm-js/deliteful#539.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant