Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8470: Upgraded codebase to Symfony 6 #78

Merged
merged 8 commits into from
Feb 4, 2025
Merged

IBX-8470: Upgraded codebase to Symfony 6 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a7f2cd2
[Composer] Bumped symfony-related packages requirements to ^6.4
alongosz Nov 12, 2024
f0a3c0d
Aligned IbexaSolrExtension method signatures with Symfony 6
alongosz Nov 12, 2024
8b50a4b
Aligned IbexaSolrBundle::build method signature with Symfony 6
alongosz Nov 12, 2024
d16c136
Aligned compiler passes methods signatures with Symfony 6
alongosz Nov 12, 2024
44dea2a
Refactored IbexaSolrExtension to extend ConfigurableExtension
alongosz Dec 11, 2024
58c08bf
Added strict return types to Search Handler `find*` methods
alongosz Dec 11, 2024
9d25f37
[PHPStan] Improved type-hinting in Search Handler and ResultExtractor
alongosz Dec 12, 2024
903bc7c
[PHPStan] Removed resolved issues from the baseline
alongosz Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
"ext-xmlwriter": "*",
"ibexa/core": "~5.0.x-dev",
"netgen/query-translator": "^1.0.2",
"symfony/http-kernel": "^5.0",
"symfony/dependency-injection": "^5.0",
"symfony/console": "^5.0",
"symfony/config": "^5.0",
"symfony/framework-bundle": "^5.0",
"symfony/http-client": "^5.4"
"symfony/http-kernel": "^6.4",
"symfony/dependency-injection": "^6.4",
"symfony/console": "^6.4",
"symfony/config": "^6.4",
"symfony/framework-bundle": "^6.4",
"symfony/http-client": "^6.4"
},
"require-dev": {
"ibexa/code-style": "~2.0.0",
Expand All @@ -33,8 +33,8 @@
"phpstan/phpstan-phpunit": "^1.1",
"phpstan/phpstan-symfony": "^1.2",
"phpunit/phpunit": "^9.6",
"symfony/phpunit-bridge": "^5.4",
"symfony/proxy-manager-bridge": "^5.4"
"symfony/phpunit-bridge": "^6.4",
"symfony/proxy-manager-bridge": "^6.4"
},
"autoload": {
"psr-4": {
Expand Down
155 changes: 0 additions & 155 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,91 +55,6 @@ parameters:
count: 1
path: src/bundle/DependencyInjection/Configuration.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:buildBoostFactorMap\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:buildBoostFactorMap\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureBoostMap\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureBoostMap\\(\\) has parameter \\$connectionParams with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureIndexingDepth\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureIndexingDepth\\(\\) has parameter \\$connectionParams with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureSearchServices\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:configureSearchServices\\(\\) has parameter \\$connectionParams with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:defineEndpoint\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:defineEndpoint\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:getConfiguration\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:load\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:load\\(\\) has parameter \\$configs with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:processConnectionConfiguration\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\DependencyInjection\\\\IbexaSolrExtension\\:\\:processConnectionConfiguration\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Parameter \\#1 \\$configuration of method Symfony\\\\Component\\\\DependencyInjection\\\\Extension\\\\Extension\\:\\:processConfiguration\\(\\) expects Symfony\\\\Component\\\\Config\\\\Definition\\\\ConfigurationInterface, Symfony\\\\Component\\\\Config\\\\Definition\\\\ConfigurationInterface\\|null given\\.$#"
count: 1
path: src/bundle/DependencyInjection/IbexaSolrExtension.php

-
message: "#^Method Ibexa\\\\Bundle\\\\Solr\\\\IbexaSolrBundle\\:\\:build\\(\\) has no return type specified\\.$#"
count: 1
path: src/bundle/IbexaSolrBundle.php

-
message: "#^Method Ibexa\\\\Contracts\\\\Solr\\\\Query\\\\CriterionVisitor\\:\\:escapeQuote\\(\\) should return string but returns string\\|null\\.$#"
count: 1
Expand Down Expand Up @@ -180,61 +95,6 @@ parameters:
count: 1
path: src/contracts/ResultExtractor/AggregationResultExtractor/TermAggregationKeyMapper.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateCriterionVisitorPass\\:\\:addHandlers\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateCriterionVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateCriterionVisitorPass\\:\\:addHandlers\\(\\) has parameter \\$handlers with no type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateCriterionVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateCriterionVisitorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateCriterionVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateFacetBuilderVisitorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateFacetBuilderVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateFacetBuilderVisitorPass\\:\\:processVisitors\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateFacetBuilderVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateFacetBuilderVisitorPass\\:\\:processVisitors\\(\\) has parameter \\$name with no type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateFacetBuilderVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateSortClauseVisitorPass\\:\\:addHandlers\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateSortClauseVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateSortClauseVisitorPass\\:\\:addHandlers\\(\\) has parameter \\$handlers with no type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateSortClauseVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\AggregateSortClauseVisitorPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/AggregateSortClauseVisitorPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\BaseFieldMapperPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/BaseFieldMapperPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\Container\\\\Compiler\\\\EndpointRegistryPass\\:\\:process\\(\\) has no return type specified\\.$#"
count: 1
path: src/lib/Container/Compiler/EndpointRegistryPass.php

-
message: "#^Method Ibexa\\\\Solr\\\\CoreFilter\\:\\:apply\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -615,11 +475,6 @@ parameters:
count: 2
path: src/lib/Handler.php

-
message: "#^Cannot access property \\$valueObject on Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\Content\\\\Search\\\\SearchHit\\|false\\.$#"
count: 1
path: src/lib/Handler.php

-
message: "#^Method Ibexa\\\\Solr\\\\Handler\\:\\:bulkIndexContent\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -670,11 +525,6 @@ parameters:
count: 1
path: src/lib/Handler.php

-
message: "#^Method Ibexa\\\\Solr\\\\Handler\\:\\:findSingle\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content but returns Ibexa\\\\Contracts\\\\Core\\\\Repository\\\\Values\\\\ValueObject\\.$#"
count: 1
path: src/lib/Handler.php

-
message: "#^Method Ibexa\\\\Solr\\\\Handler\\:\\:generateDocument\\(\\) should return Ibexa\\\\Contracts\\\\Core\\\\Search\\\\Document but returns array\\<Ibexa\\\\Contracts\\\\Core\\\\Search\\\\Document\\>\\.$#"
count: 1
Expand Down Expand Up @@ -720,11 +570,6 @@ parameters:
count: 1
path: src/lib/Handler.php

-
message: "#^Return type \\(Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\) of method Ibexa\\\\Solr\\\\Handler\\:\\:findSingle\\(\\) should be compatible with return type \\(Ibexa\\\\Contracts\\\\Core\\\\Persistence\\\\Content\\\\ContentInfo\\) of method Ibexa\\\\Contracts\\\\Core\\\\Search\\\\Handler\\:\\:findSingle\\(\\)$#"
count: 2
path: src/lib/Handler.php

-
message: "#^Method Ibexa\\\\Solr\\\\Indexer\\:\\:purge\\(\\) has no return type specified\\.$#"
count: 1
Expand Down
Loading
Loading