IBX-5741: Fixed attribute preview cannot be collapsed (#91)

For more details see https://issues.ibexa.co/browse/IBX-5741 and #91
ibexa · Jun 23, 2023 · cd54c30 · cd54c30
1 parent 43cf506
commit cd54c30
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js b/src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-ui.js
@@ -87,6 +87,13 @@ class IbexaCustomTagUI extends Plugin {
         this.attributesView.setChildren({
             attributes: this.config.attributes,
         });
+
+        clickOutsideHandler({
+            emitter: this.attributesView,
+            activator: () => this.balloon.hasView(this.attributesView),
+            contextElements: [this.balloon.view.element],
+            callback: () => this.hideAttributes(),
+        });
     }
 
     createFormView() {
@@ -132,7 +139,7 @@ class IbexaCustomTagUI extends Plugin {
 
         this.balloon.add({
             view: this.attributesView,
-            position: this.getBalloonPositionData(),
+            position: { target },
         });
 
         this.balloon.updatePosition({ target });

diff --git a/src/bundle/Resources/public/js/CKEditor/custom-tags/ui/custom-tag-attributes-view.js b/src/bundle/Resources/public/js/CKEditor/custom-tags/ui/custom-tag-attributes-view.js
@@ -1,7 +1,7 @@
 import View from '@ckeditor/ckeditor5-ui/src/view';
 import IbexaButtonView from '../../common/button-view/button-view';
 
-class IbexaCustomTagFormView extends View {
+class IbexaCustomTagAttributesView extends View {
     constructor(props) {
         super(props);
 
@@ -89,4 +89,4 @@ class IbexaCustomTagFormView extends View {
     }
 }
 
-export default IbexaCustomTagFormView;
+export default IbexaCustomTagAttributesView;