Fixed passing DateTime instances into DoctrineDatabase::findBy() methods
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
force-pushed
the
fix-date-time-find-by
branch
from
7d88261 to
0e4b952
Compare
adamwojs
force-pushed
the
fix-date-time-find-by
branch
from
9f48398 to
2c48633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to fix an issue where specific types representing database values - namely,
DateTimeInterfacein context of Doctrine DBAL date & time types - are not working properly.This allows for example:
as well as using
Comparisonoperators with date time objects, without formatting them explicitly in the gateway/handler.Reported deprecations are due to Doctrine internal calls, which we are mocking during tests.
For QA:
Documentation: