IBX-6413: Fixes minQueryLength test to stick to parameter's meaning #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ibexa.site_access.config.<scope>.search.suggestion.min_query_length: 3` should mean that suggestion start to be made for a 3 character long text. With `<=` it was starting at 4 characters. With `<` it starts at 3.
|
Kudos, SonarCloud Quality Gate passed!
|
7 tasks
adamwojs
approved these changes
Nov 20, 2023
|
I was just about to report this issue :D |
adriendupuis
changed the title
dew326
approved these changes
Nov 20, 2023
|
Thank you for contribution @adriendupuis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ibexa.site_access.config.<scope>.search.suggestion.min_query_length: 3should mean that suggestion start to be made for a 3 character long text.<=it was starting at 4 characters.<it starts at 3.Checklist:
$ composer fix-cs)