IBX-6260: Fixed preview voter taking language priority into consideration #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
webhdx
approved these changes
Aug 16, 2023
konradoboza
approved these changes
Aug 16, 2023
micszo
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible siteAccesses to display given content should not take language order into consideration. It should be matter of selector, to pick the most proper one out of those.
This same issue came up, when having identical siteAccess configuration (as in ticket), you tried to just translate any other content into other language and you get
Preview unavailableinformation, when there clearly was one to do it.Same issue goes up in 3.3 version, but as there, page-builder logic is separated from this one, it would require different approach (and it is possible to translate landing page there, it is only issue of the preview, so it is not as severe there).
For usage & tests:
https://github.com/ibexa/page-builder/pull/237
Checklist:
$ composer fix-cs)