Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6240: Create general css classes for switcher (from edit form left menu) #850

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6240
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-6240-switcher-classes branch from 928fe14 to 0646b2f Compare August 9, 2023 12:05
@micszo micszo self-assigned this Aug 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual Tests & Regressions passed.
Manual tests of switcher against Nightly OK.
Behat updated.

QA Approved on Ibexa Commerce 4.6.x-dev.

@micszo micszo removed their assignment Aug 17, 2023
@mikadamczyk mikadamczyk merged commit 89e2386 into main Aug 17, 2023
@mikadamczyk mikadamczyk deleted the IBX-6240-switcher-classes branch August 17, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants