IBX-3069: Fixed selection input in firefox #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Jul 14, 2023
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.contenttype.edit.js
Outdated
Show resolved
Hide resolved
dew326
approved these changes
Jul 20, 2023
GrabowskiM
requested changes
Jul 20, 2023
lucasOsti
approved these changes
Jul 25, 2023
GrabowskiM
approved these changes
Jul 26, 2023
GrabowskiM
force-pushed
the
ibx-3069-selection-input-in-firefox
branch
from
199a7fb to
a33a083
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jwibexa
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed selection input in firefox by disabling draggable when filed expanded
Updated icon chevrons when hide and show
Added hover to draggable button/icon
Explanation
What is this PR for?
This PR fixed inputs in Firefox browser.
What it means?
Draggable in firefox have issue when there is input insde draggable content.
Probabbly browser have no idea if it should drag or select text.
What was solution?
There was implemented event listener on mouseenter and mouseleave to disable draggable when input is hovered.
There still might be problem with choosing input from keyboard but it can be done the same on focus.
Checklist:
yarn test)