IBX-5784, IBX-5743: CkEditor toolbar overflow #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
requested changes
Jun 19, 2023
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
Gengar-i
changed the title
OstafinL
approved these changes
Jun 20, 2023
dew326
requested changes
Jun 21, 2023
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
| const classes = { | ||
| 'ibexa-backdrop--transparent': this.isTransparent, | ||
| }; | ||
| const backdropClasses = Object.keys(classes).filter((property) => classes[property]); |
There was a problem hiding this comment.
it seems like you want to have some createCssClassNames we have in react, maybe it is time to make this helper global?
There was a problem hiding this comment.
It is only usefull in my opinion in react. I do not want to make single string, just array of them.
I could use createCssClassNames and than split them but what is the point.
tischsoic
reviewed
Jun 21, 2023
src/bundle/Resources/public/js/scripts/helpers/backdrop.helper.js
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
dew326
approved these changes
Jun 27, 2023
GrabowskiM
approved these changes
Jun 29, 2023
tomaszszopinski
approved these changes
Jul 10, 2023
|
Regression build (all green) -> ibexa/commerce#303 |
|
Merge to 4.6: 6248a50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ibx 5784 cd editor toolbar overflow
Checklist: