Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] IBX-4482 Fix for toggle button enabled #786

Merged
merged 1 commit into from
May 11, 2023
Merged

[Behat] IBX-4482 Fix for toggle button enabled #786

merged 1 commit into from
May 11, 2023

Conversation

bogusez
Copy link
Contributor

@bogusez bogusez commented May 10, 2023 •
edited
Loading

JIRA: IBX-4482

A bug fix for toggle button enabled on user creation form.

An example of failed build: https://github.com/ibexa/content/actions/runs/4919955972/jobs/8788215942

  • Code follows the code style of this project (use $ composer fix-cs).
  • Change requires a change to the documentation.
  • Code is ready for a review.

@bogusez bogusez self-assigned this May 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bogusez bogusez mentioned this pull request May 10, 2023
Closed
mnocon
mnocon approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bogusez bogusez mentioned this pull request May 10, 2023
Closed
micszo
micszo approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this requires dark js voodoo magic? 😄

This was referenced May 11, 2023
Closed
Closed
@bogusez
Copy link
Contributor Author

bogusez commented May 11, 2023

Based on 10 iterations all passed in terms of userCreation.feature. Failed builds aren't related with userCreation test scenarios. For me it's a green light and we can merge it.

ibexa/experience#172
ibexa/commerce#259

@micszo
Together with @mnocon we decided that we won't merge it up to main branch as the issue only occur on v4.4
btw. 4.4 will be EOM very soon.

@micszo micszo merged commit 01ea505 into 4.4 May 11, 2023
@micszo micszo deleted the IBX-4482_fix_for_enable_toggle_button_on_user_creation_form branch May 11, 2023 13:25
mnocon pushed a commit that referenced this pull request Jun 19, 2023
@bogusez @mnocon
[Behat] IBX-4482 Fix for toggle button enabled (#786)
b179900 
Co-authored-by: Bogdan Mazur <[email protected]>
@mnocon mnocon mentioned this pull request Jun 19, 2023
Merged
micszo pushed a commit that referenced this pull request Jun 19, 2023
@mnocon @bogusez
[Behat] IBX-4482 Fix for toggle button enabled (#786) (#814)
a4392dd 
Co-authored-by: Bogdan Mazur <[email protected]>
Co-authored-by: Bogdan Mazur <[email protected]>
GrabowskiM pushed a commit that referenced this pull request Jul 19, 2023
Revert "[Behat] IBX-4482 Fix for toggle button enabled (#786)"
c9c5779 
This reverts commit 01ea505.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@micszo micszo micszo approved these changes

@mnocon mnocon mnocon approved these changes

@jwibexa jwibexa Awaiting requested review from jwibexa

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@bogusez bogusez

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bogusez @mnocon @micszo @katarzynazawada @mikadamczyk @Nattfarinn