IBX-5622: Adaptive filters styling improvements #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Apr 21, 2023
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-5622 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
approved these changes
Apr 21, 2023
Gengar-i
approved these changes
Apr 21, 2023
GrabowskiM
approved these changes
Apr 24, 2023
dew326
reviewed
Apr 24, 2023
| } | ||
|
|
||
| &__collapsible { | ||
| border-top: calculateRem(1px) solid $ibexa-color-light; | ||
| transition: all $ibexa-admin-transition-duration $ibexa-admin-transition; | ||
| transition: none; |
There was a problem hiding this comment.
do we need none, are we overriding something?
There was a problem hiding this comment.
Even though it does not override other transition it affects animation.
dew326
approved these changes
Apr 24, 2023
bogusez
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.