Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5576: [Payments] Issues with filters #763

Merged
merged 1 commit into from
Apr 26, 2023
Merged

IBX-5576: [Payments] Issues with filters #763

merged 1 commit into from
Apr 26, 2023

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5576
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-5576-clear-filters-fix branch from deab405 to 6751020 Compare April 20, 2023 11:21
katarzynazawada
katarzynazawada requested changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i select 4 values ​​in the Status filter, click Apply, the width of the filter changes https://recordit.co/4RY3BwnBkA

@GrabowskiM GrabowskiM force-pushed the IBX-5576-clear-filters-fix branch from 6751020 to 3ab831c Compare April 25, 2023 13:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

katarzynazawada
katarzynazawada approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue resolved in https://github.com/ibexa/payment/pull/82

@dew326 dew326 merged commit 4ea024e into main Apr 26, 2023
@dew326 dew326 deleted the IBX-5576-clear-filters-fix branch April 26, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GrabowskiM @tischsoic @dew326 @lucasOsti @katarzynazawada @Gengar-i