Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-5561: [Payments] Cannot use Created at/Updated at filter #762

Merged

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5561
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM force-pushed the IBX-5561-payments-cannot-use-created-atupdated-at-filter branch from 99f110c to 2b76c32 Compare April 19, 2023 13:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now user can select date only in date picker and 500 error occurs https://recordit.co/pB4cCQK6hp
Screenshot 2023-04-21 at 10 54 13

@GrabowskiM
Copy link
Contributor Author

Now user can select date only in date picker and 500 error occurs https://recordit.co/pB4cCQK6hp Screenshot 2023-04-21 at 10 54 13

That's backend error when only min or only max is provided, probably it would be best to create for it new issue for backend, unless @adamwojs has some quick fix and he'd like to do it here?

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error reported as follow-up here: https://issues.ibexa.co/browse/IBX-5631

@dew326 dew326 merged commit af5dea5 into main Apr 24, 2023
@dew326 dew326 deleted the IBX-5561-payments-cannot-use-created-atupdated-at-filter branch April 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants