Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3529: changed header list title #638

Merged
merged 12 commits into from
Jan 4, 2023
Merged

IBX-3529: changed header list title #638

merged 12 commits into from
Jan 4, 2023

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Nov 8, 2022 •
edited
Loading

Question Answer
Tickets IBX-3529
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Changed header list on pages in admin-ui

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@Gengar-i Gengar-i changed the base branch from main to 4.2 November 8, 2022 13:33
@Gengar-i Gengar-i changed the title IBX-3529: change header list title change IBX-3529: changed header list title change Nov 8, 2022
@Gengar-i Gengar-i changed the title IBX-3529: changed header list title change IBX-3529: changed header list title Nov 8, 2022
@Gengar-i Gengar-i requested a review from lucasOsti November 10, 2022 11:20
@dew326 dew326 requested a review from tischsoic November 21, 2022 10:05
@mikadamczyk mikadamczyk requested review from webhdx, a team and Nattfarinn November 22, 2022 15:16
mikadamczyk
mikadamczyk reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@mikadamczyk mikadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful if you can provide in the description an example of how this will be extended (in the context of custom translation). We are losing translations with this solution. Maybe we should internally add translations for new list.headline, list.headline.results, and list.headline.results.search for the most popular languages: e.g. fr, de, es, and pl

src/bundle/Resources/translations/content_type.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/fieldtypes_preview.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/forms.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/list.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/list.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/views/themes/admin/trash/list.html.twig Outdated Show resolved Hide resolved
@Gengar-i Gengar-i requested a review from tischsoic November 23, 2022 17:10
@mikadamczyk mikadamczyk requested a review from alongosz November 24, 2022 10:12
Gengar-i
Gengar-i commented Nov 24, 2022
View reviewed changes
src/bundle/Resources/views/themes/admin/ui/component/macros.html.twig
@@ -8,3 +8,18 @@
{%- endif -%}
{%- endfor -%}
{%- endmacro -%}

{% macro results_headline(count, has_filters = false, phrase = null) %}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we want have everywhere the same list header on pages, there was implemented macro which can be used in every package. It takes filters and phrase if search or filters are avaiable.

@Gengar-i
Copy link
Contributor Author

image

@Gengar-i
Copy link
Contributor Author

image

@Gengar-i
Copy link
Contributor Author

image

@Gengar-i Gengar-i force-pushed the IBX-3529-header-list branch from bea2a7d to 91ba86f Compare December 1, 2022 10:38
@Gengar-i Gengar-i force-pushed the IBX-3529-header-list branch from a1061e3 to 9b16b03 Compare December 28, 2022 11:27
@Gengar-i Gengar-i force-pushed the IBX-3529-header-list branch from 9b16b03 to 9f03b09 Compare December 28, 2022 14:57
katarzynazawada
katarzynazawada requested changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule needs to be implemented:

Products
For search results:
Result (number)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.9% 6.9% Duplication

@katarzynazawada katarzynazawada mentioned this pull request Jan 4, 2023
Closed
@dew326 dew326 merged commit 3cff7b5 into 4.3 Jan 4, 2023
@dew326 dew326 deleted the IBX-3529-header-list branch January 4, 2023 14:41
@Gengar-i
Copy link
Contributor Author

Gengar-i commented Jan 4, 2023

Merge to main: 15f9906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@kisztof kisztof kisztof approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@dew326 dew326

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.