IBX-4005: Broken tooltips.hideAll() function #599
Conversation
| @@ -132,6 +132,8 @@ | |||
| </div>`, | |||
| }); | |||
|
|
|||
| tooltipNode.title = ''; | |||
There was a problem hiding this comment.
Could you explain how it works? :)
There was a problem hiding this comment.
We were always using [title] selector to get all nodes for tooltips, both for parsing and hiding all tooltips. So far Bootstrap was using .setAttribute('title', '') in its constructor, but in 5.2.0 they introduced .removeAttribute('title') instead, which removed title parameter, I set it back here, so that I could still use same selector for getting all tooltips
There was a problem hiding this comment.
Really appreciate your explanation! 😊
There was a problem hiding this comment.
If you parse a second time the same tooltipNode and title is the empty string will bootstrap change the tooltip to empty string?
There was a problem hiding this comment.
not anymore, after last commit ;)
|
|
||
| tooltipNode.dataset.originalTitle = tooltipNode.title; | ||
| tooltipNode.dataset.originalTitle = tooltipInstance ? tooltipInstance._getTitle() : tooltipNode.title; | ||
|
|
||
| new bootstrap.Tooltip(tooltipNode, { |
There was a problem hiding this comment.
We are creating a tooltip instance even in a case in which tooltipInstance returned by getInstance is not null? Isn't this the duplication of instances? 🤔
|
Kudos, SonarCloud Quality Gate passed!
|
In case of testing it on main branch, it requires new installation with fixed tag for admin-ui-assets (wrong BS version installed)
Checklist:
$ composer fix-cs)