IBX-3937: First button primary- creating/editing/updating forms #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Oct 3, 2022
adamwojs
approved these changes
Oct 4, 2022
This was referenced Oct 11, 2022
GrabowskiM
force-pushed
the
IBX-3937-first-button-primary
branch
from
8d27d1a to
110df04
Compare
mikadamczyk
approved these changes
Oct 11, 2022
|
@GrabowskiM "Edit" primary in Object states \cc @MalgorzataPabich
and one level deeper
|
tischsoic
reviewed
Oct 12, 2022
| @@ -3,6 +3,13 @@ | |||
| {% block root %} | |||
| {% set menu_items %} | |||
| {% for item in item.children %} | |||
| {% if loop.first %} | |||
| {%- do item.setExtras(item.extras|merge({ | |||
There was a problem hiding this comment.
Not sure whether we really want to do it always and do not provide an option to opt-out.
There was a problem hiding this comment.
Turns out we want this behaviour. Personally, I'm not convinced, but... 🙂
tischsoic
approved these changes
Oct 12, 2022
|
@GrabowskiM could you in scope of this also add primary colour for hovers in subitems? \cc @MalgorzataPabich Nagranie.z.ekranu.2022-10-12.o.13.21.32.mov |
GrabowskiM
force-pushed
the
IBX-3937-first-button-primary
branch
from
fc17f0c to
7288086
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
micszo
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)