Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4818: remove ibexa-font-sans-serif SCSS mixin usage #572

Merged
merged 1 commit into from
Jan 17, 2023
Merged

IBX-4818: remove ibexa-font-sans-serif SCSS mixin usage #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/bundle/Resources/public/scss/_alerts.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@

&__title,
&__subtitle {
@include ibexa-font-sans-serif();

word-break: break-word;
}

Expand Down
1 change: 0 additions & 1 deletion src/bundle/Resources/public/scss/_dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.ibexa-dropdown {
position: relative;
font-family: $font-family-sans-serif;
font-size: $ibexa-text-font-size-medium;
min-width: calculateRem(200px);

Expand Down
4 changes: 0 additions & 4 deletions src/bundle/Resources/public/scss/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ form:not(.form-inline) {
}

.ibexa-form-error {
@include ibexa-font-sans-serif();

display: flex;
font-size: $ibexa-text-font-size-small;
font-style: normal;
Expand All @@ -90,8 +88,6 @@ form:not(.form-inline) {
}

.ibexa-form-help {
@include ibexa-font-sans-serif();

display: flex;
font-size: $ibexa-text-font-size-small;
color: $ibexa-color-dark-400;
Expand Down
4 changes: 0 additions & 4 deletions src/bundle/Resources/public/scss/_inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@
&--text,
&--textarea,
&--date {
@include ibexa-font-sans-serif();

font-size: $ibexa-text-font-size-medium;
color: $ibexa-color-dark;
line-height: calculateRem(21px);
Expand Down Expand Up @@ -78,8 +76,6 @@
}

&::placeholder {
@include ibexa-font-sans-serif();

color: $ibexa-color-dark-400;
font-size: $ibexa-text-font-size-medium;
line-height: calculateRem(21px);
Expand Down
1 change: 0 additions & 1 deletion src/bundle/Resources/public/scss/_labels.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.ibexa-label {
@include label-required();
@include ibexa-font-sans-serif();

font-size: $ibexa-text-font-size-small;
color: $ibexa-color-dark-400;
Expand Down
7 changes: 0 additions & 7 deletions src/bundle/Resources/public/scss/_tables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.ibexa-table {
font-family: $font-family-sans-serif;
font-size: $ibexa-text-font-size;
line-height: calculateRem(24px);
border-spacing: 0;
Expand Down Expand Up @@ -57,8 +56,6 @@
}

&__empty-table-text {
@include ibexa-font-sans-serif();

max-width: calculateRem(440px);
margin-left: calculateRem(56px);
color: $ibexa-color-dark-400;
Expand All @@ -77,8 +74,6 @@

&__header-cell {
.table & {
@include ibexa-font-sans-serif();

font-size: $ibexa-text-font-size-small;
font-weight: normal;
color: $ibexa-color-dark-400;
Expand Down Expand Up @@ -206,8 +201,6 @@
border-bottom: calculateRem(1px) solid $ibexa-color-dark-200;

&__headline {
@include ibexa-font-sans-serif();

font-size: $ibexa-text-font-size-large;
line-height: calculateRem(33px);
color: $ibexa-color-black;
Expand Down
1 change: 0 additions & 1 deletion src/bundle/Resources/public/scss/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
color: $ibexa-color-dark;
font-size: calculateRem(14px);
cursor: pointer;
font-family: 'Noto Sans';

.ibexa-tabs__toggler-show {
display: none;
Expand Down
2 changes: 0 additions & 2 deletions src/bundle/Resources/public/scss/mixins/_drag-and-drop.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@
}

@mixin drag-item-label {
@include ibexa-font-sans-serif();

font-size: $ibexa-text-font-size-medium;
font-weight: 600;
}
Expand Down
1 change: 1 addition & 0 deletions src/bundle/Resources/public/scss/mixins/_font.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// deprecated - will be removed in 5.0
@mixin ibexa-font-sans-serif() {
font-family: $font-family-sans-serif;
letter-spacing: calculateRem(0.12px);
Expand Down
1 change: 0 additions & 1 deletion src/bundle/Resources/public/scss/ui/modules/content-tree/_popup.actions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.c-popup-actions {
font-family: $font-family-sans-serif;
font-size: $ibexa-text-font-size-medium;
cursor: pointer;
margin-right: calculateRem(8px);
Expand Down