IBX-2622: As a developer I want to have dynamic Dropdown #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Mar 30, 2022
| @@ -283,6 +289,65 @@ | |||
| return this.itemsContainer; | |||
| } | |||
|
|
|||
| hasChangedOptions(mutationList) { | |||
| return mutationList.reduce( | |||
lucasOsti
approved these changes
Mar 30, 2022
tischsoic
requested changes
Mar 31, 2022
Comment on lines
300
to
306
| if (this.canSelectOnlyOne) { | ||
| const selectedItem = this.sourceInput.querySelector(`[value="${this.sourceInput.value}"]`); | ||
|
|
||
| return selectedItem ? [selectedItem] : []; | ||
| } | ||
|
|
||
| return [...this.sourceInput.querySelectorAll('.ibexa-input:checked')]; |
There was a problem hiding this comment.
<option>s are not ibexa-input and :checked should also work for single select
Suggested change
| if (this.canSelectOnlyOne) { | |
| const selectedItem = this.sourceInput.querySelector(`[value="${this.sourceInput.value}"]`); | |
| return selectedItem ? [selectedItem] : []; | |
| } | |
| return [...this.sourceInput.querySelectorAll('.ibexa-input:checked')]; | |
| return [...this.sourceInput.querySelectorAll(':checked')]; |
| @@ -283,6 +289,65 @@ | |||
| return this.itemsContainer; | |||
| } | |||
|
|
|||
| hasChangedOptions(mutationList) { | |||
There was a problem hiding this comment.
wdyt?
Suggested change
| hasChangedOptions(mutationList) { | |
| haveOptionsChanged(mutationList) { |
Comment on lines
327
to
328
| if (!newOptions.length) { | ||
| this.container.classList.add('ibexa-dropdown--disabled'); |
There was a problem hiding this comment.
If you remove all options (dropdown becomes disabled) and then add a new one it won't enable itself again.
Suggested change
| if (!newOptions.length) { | |
| this.container.classList.add('ibexa-dropdown--disabled'); | |
| this.container.classList.toggle('ibexa-dropdown--disabled', !newOptions.length); |
|
|
||
| createOption(value, label) { | ||
| const container = doc.createElement('div'); | ||
| const renderedTemplate = this.itemTemplate.replaceAll('{{ value }}', value).replaceAll('{{ label }}', label); |
There was a problem hiding this comment.
nitpick
Suggested change
| const renderedTemplate = this.itemTemplate.replaceAll('{{ value }}', value).replaceAll('{{ label }}', label); | |
| const itemRendered = this.itemTemplate.replaceAll('{{ value }}', value).replaceAll('{{ label }}', label); |
| } | ||
|
|
||
| recreateOptions() { | ||
| const newOptions = this.sourceInput.querySelectorAll('option'); |
There was a problem hiding this comment.
For me new is misleading, because, not all options are actually new.
dew326
approved these changes
Apr 4, 2022
GrabowskiM
force-pushed
the
IBX-2622-dynamic-dropdown
branch
from
ac8eab1 to
f872e6f
Compare
tischsoic
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)