Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2288: Use ResizeObserver for adaptive items and subitems #325

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

GrabowskiM
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2288
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@GrabowskiM GrabowskiM changed the title IBX-2288: Use ResizeObserver for adaptive items IBX-2288: Use ResizeObserver for adaptive items and subitems Feb 11, 2022
@bogusez bogusez self-assigned this Feb 17, 2022
@bogusez
Copy link
Contributor

bogusez commented Feb 17, 2022

@GrabowskiM when composer run post-install-cmd is executed then an exception occurs:

Executing script ibexa:encore:compile --config-name app [KO]
[KO]
Script ibexa:encore:compile --config-name app returned with error code 1
!!
!!
!! The "--config-name" option does not exist.
!!
!!
!! ibexa:encore:compile [-t|--timeout [TIMEOUT]] [--siteaccess [SITEACCESS]]
!!
!!
Script @auto-scripts was called via post-update-cmd

@GrabowskiM GrabowskiM force-pushed the IBX-2288-use-resize-observer branch from a23df2c to beff865 Compare February 17, 2022 13:06
@bogusez
Copy link
Contributor

bogusez commented Feb 17, 2022

@GrabowskiM when composer run post-install-cmd is executed then an exception occurs:

Executing script ibexa:encore:compile --config-name app [KO] [KO] Script ibexa:encore:compile --config-name app returned with error code 1 !! !! !! The "--config-name" option does not exist. !! !! !! ibexa:encore:compile [-t|--timeout [TIMEOUT]] [--siteaccess [SITEACCESS]] !! !! Script @auto-scripts was called via post-update-cmd

rebase solved the problem, thanks

@GrabowskiM GrabowskiM force-pushed the IBX-2288-use-resize-observer branch from beff865 to 94bc349 Compare February 18, 2022 11:39
@dew326 dew326 merged commit d59de2d into main Feb 18, 2022
@dew326 dew326 deleted the IBX-2288-use-resize-observer branch February 18, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants