IBX-1433: Search update - main and UDW #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Jan 27, 2022
•
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-1433 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
tischsoic
force-pushed
the
IBX-1433-search-update
branch
from
925ee85 to
3154c72
Compare
tischsoic
changed the title
dew326
requested changes
Jan 27, 2022
| @@ -1,8 +1,28 @@ | |||
| .c-content-table-item { | |||
| cursor: pointer; | |||
|
|
|||
| .ibexa-table__cell.ibexa-table__cell { | |||
| border: 2px solid transparent; | |||
| background-color: lighten($ibexa-color-white, 15%); | ||
| transform: scale(1); // it is a hack to have box-shadow on table row ref. https://stackoverflow.com/a/47992341 | ||
| transition: all $ibexa-admin-transition-duration $ibexa-admin-transition; | ||
| box-shadow: 4px 22px 47px 0 rgba(0,63,255,0.05); |
| box-shadow: 4px 22px 47px 0 rgba(0,63,255,0.05); | ||
|
|
||
| .ibexa-table__cell.ibexa-table__cell { | ||
| border-color: #E0E0E8; |
GrabowskiM
requested changes
Jan 27, 2022
| } | ||
| } | ||
|
|
||
| &__results-language { | ||
| display: inline-block; | ||
| margin-bottom: 8px; |
src/bundle/Resources/public/scss/ui/modules/universal-discovery/_top.menu.search.input.scss
Show resolved
Hide resolved
| isSearchOpened: PropTypes.bool.isRequired, | ||
| }; | ||
|
|
||
| TopMenuSearchInput.defaultProps = {}; |
There was a problem hiding this comment.
unnecessary defaultProps
OstafinL
reviewed
Jan 27, 2022
| left: calculateRem(65px); | ||
| border: none; | ||
| padding: 0; | ||
| font-family: $headings-font-family; |
There was a problem hiding this comment.
Should we create ibexa variable for this?
tischsoic
force-pushed
the
IBX-1433-search-update
branch
from
3fd5db1 to
e1fe4a6
Compare
dew326
approved these changes
Jan 28, 2022
OstafinL
approved these changes
Jan 28, 2022
GrabowskiM
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.