Refactored ContentType::isContainer property to method changed #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Feb 27, 2025
| @@ -4045,6 +4040,11 @@ parameters: | |||
| count: 1 | |||
| path: src/lib/Form/Data/FormMapper/ContentTypeDraftMapper.php | |||
|
|
|||
| - | |||
There was a problem hiding this comment.
Remember to regenerate baseline after merging related PRs - this method should be accessible.
| @@ -121,7 +121,7 @@ private function createContentType(FieldDefinitionCollectionInterface $fieldDefi | |||
|
|
|||
| private function createContentTypeDraft(ContentType $contentType): ContentTypeDraft | |||
| { | |||
| return new ContentTypeDraft(['innerContentType' => $contentType]); | |||
| return new ContentTypeDraft(['innerContentType' => $contentType, 'isContainer' => false]); | |||
There was a problem hiding this comment.
Again - should we mark isContainer as false by default?
adamwojs
approved these changes
Feb 27, 2025
mikadamczyk
approved these changes
Feb 28, 2025
|
adamwojs
deleted the
refactoring-ContentType-isContainer-property-to-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Refactored ContentType::isContainer property to method changed