IBX-8671: Missing notification text when removing required field #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-8671-Missing-notification-text-when-removing-required-field
branch
from
1e8926c to
3b80170
Compare
GrabowskiM
requested changes
Aug 7, 2024
GrabowskiM
approved these changes
Aug 7, 2024
dew326
approved these changes
Aug 8, 2024
lucasOsti
force-pushed
the
IBX-8671-Missing-notification-text-when-removing-required-field
branch
from
3b80170 to
193679d
Compare
This was referenced Aug 12, 2024
mikadamczyk
requested changes
Aug 12, 2024
| throw Error(response.statusText); | ||
| const Translator = getTranslator(); | ||
| const defaultErrorMsg = Translator.trans( | ||
| /*@Desc("Something went wrong. Try to refresh the page or contact you administrator.")*/ 'error.request.default_msg', |
There was a problem hiding this comment.
Suggested change
| /*@Desc("Something went wrong. Try to refresh the page or contact you administrator.")*/ 'error.request.default_msg', | |
| /*@Desc("Something went wrong. Try to refresh the page or contact your administrator.")*/ 'error.request.default_msg', |
We have two "administrator" spelling variants, with lower and upper case letters. Is this whole phrase correct? @juskora
|
bogusez
approved these changes
Aug 12, 2024
mikadamczyk
approved these changes
Aug 12, 2024
dew326
deleted the
IBX-8671-Missing-notification-text-when-removing-required-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: