IBX-7981: Improved folder configuration #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
changed the title
ViniTou
approved these changes
Apr 5, 2024
konradoboza
approved these changes
Apr 8, 2024
mikadamczyk
approved these changes
Apr 8, 2024
Nattfarinn
approved these changes
Apr 8, 2024
* Added image mappings parameter * Adjusted DamWidget * [Tests] Adjusted DamWidgetTest * [PHPStan] Added improvements
|
This was referenced Apr 17, 2024
bogusez
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides improved folder configuration that returns array of field definition identifiers extracted from name schema. Previous solution with manually pointing field type identifier did not account case when name schema contains more than one field definition identifier. Now we will iterate through array of identifiers and edit first matched field.
For QA:
Provided configuration for DamWidget should contains all field definition identifiers from name schema setting.
Documentation: