Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7459: Tabs updated with new design #1118

Merged
merged 3 commits into from
Jan 30, 2024
Merged

IBX-7459: Tabs updated with new design #1118

merged 3 commits into from
Jan 30, 2024

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Jan 16, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7459
Type bug
Target version v4.6
BC breaks no
Doc needed no

Tabs update:

  • Removed border change on hover
  • Added font change on hover

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@adamwojs
Copy link
Member

@Gengar-i Could you please summarize changes in compare to previous design?

@Gengar-i Gengar-i force-pushed the ibx-7459-tabs-update branch from eabcba9 to 45fec48 Compare January 29, 2024 14:13
@Gengar-i
Copy link
Contributor Author

Gengar-i commented Jan 29, 2024 •
edited
Loading

Active 'fields'
Hover on 'view'
image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adamwojs adamwojs merged commit 1cf3a4d into main Jan 30, 2024
22 checks passed
@adamwojs adamwojs deleted the ibx-7459-tabs-update branch January 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Gengar-i @adamwojs @GrabowskiM @dew326 @lucasOsti @mikadamczyk @Nattfarinn @ciastektk @ViniTou @tomaszszopinski