Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7505: Fix unnecessary +0 text in React dropdown #1106

Merged
merged 1 commit into from
Jan 9, 2024
Merged

IBX-7505: Fix unnecessary +0 text in React dropdown #1106

merged 1 commit into from
Jan 9, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Jan 8, 2024 •
edited by Gengar-i
Loading

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7148
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@tischsoic tischsoic self-assigned this Jan 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@barbaragr barbaragr self-assigned this Jan 9, 2024
barbaragr
barbaragr approved these changes Jan 9, 2024
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@adamwojs adamwojs merged commit 60c1b16 into main Jan 9, 2024
23 checks passed
@adamwojs adamwojs deleted the IBX-7505-unnecessary-0-in-React-dropdown branch January 9, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@barbaragr barbaragr barbaragr approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@tischsoic tischsoic

@dew326 dew326

@barbaragr barbaragr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tischsoic @dew326 @barbaragr @Gengar-i @adamwojs