Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7494: [Focus mode] As a User, I want to see Content Tree in dark theme #1105

Merged
merged 10 commits into from
Jan 17, 2024
Merged

IBX-7494: [Focus mode] As a User, I want to see Content Tree in dark theme #1105

merged 10 commits into from
Jan 17, 2024

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Jan 8, 2024 •
edited
Loading

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7494
Type feature
Target Ibexa version v4.6
BC breaks no

With:
https://github.com/ibexa/page-builder/pull/324
https://github.com/ibexa/taxonomy/pull/262
https://github.com/ibexa/site-context/pull/27
https://github.com/ibexa/content-tree/pull/63
#1105
https://github.com/ibexa/tree-builder/pull/127

This PR extracts to css variables, so that theming is easier

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@GrabowskiM GrabowskiM marked this pull request as draft January 8, 2024 09:31
@GrabowskiM GrabowskiM changed the title IBX-7494: [Focus mode] As a User, I want to see Content Tree in dark … IBX-7494: [Focus mode] As a User, I want to see Content Tree in dark theme Jan 11, 2024
@GrabowskiM GrabowskiM marked this pull request as ready for review January 11, 2024 14:29
@Gengar-i Gengar-i force-pushed the IBX-7494-dark-theme branch from 370ea0d to d0317f4 Compare January 16, 2024 14:50
@barbaragr barbaragr self-assigned this Jan 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

barbaragr
barbaragr approved these changes Jan 17, 2024
View reviewed changes
Copy link

@barbaragr barbaragr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was big! 🎉

@webhdx webhdx merged commit 5425606 into main Jan 17, 2024
22 checks passed
@webhdx webhdx deleted the IBX-7494-dark-theme branch January 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@barbaragr barbaragr barbaragr approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@barbaragr barbaragr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.