Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7401: Fixed input file type validation for image asset field #1063

Merged
merged 3 commits into from
Dec 15, 2023
Merged

IBX-7401: Fixed input file type validation for image asset field #1063

merged 3 commits into from
Dec 15, 2023

Conversation

ciastektk
Copy link
Contributor

https://issues.ibexa.co/browse/IBX-7401

Question Answer
Tickets
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Tests pass? yes/no
Doc needed? yes/no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ciastektk ciastektk force-pushed the ibx-7401-fixed-image-asset-input-validation branch from dfc8b22 to d50ce3b Compare December 14, 2023 15:18
@lucasOsti lucasOsti self-requested a review December 14, 2023 15:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza marked this pull request as ready for review December 14, 2023 16:05
@konradoboza konradoboza added Bug Something isn't working Ready for review labels Dec 14, 2023
@konradoboza
Copy link
Contributor

Restored invoking resetInputField(), otherwise, we end up with validation issue coming from Image FieldType which isn't the easiest to digest for the end-users. Also, added failsafe in case no allowed extensions are configured (all should be allowed in this case).

mnocon
mnocon approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

Tested on both image and image asset fieldtypes, with mime restrictions set to default and custom values.

@webhdx webhdx merged commit 32c3aea into main Dec 15, 2023
22 checks passed
@webhdx webhdx deleted the ibx-7401-fixed-image-asset-input-validation branch December 15, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

@Gengar-i Gengar-i Awaiting requested review from Gengar-i

Assignees

@dew326 dew326

Labels
Bug Something isn't working QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ciastektk @konradoboza @mnocon @dew326 @lucasOsti @Gengar-i @webhdx