fixes after cr

ibexa · Mar 10, 2023 · 7dac0bb · 7dac0bb
1 parent 89cf887
commit 7dac0bb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js b/src/bundle/Resources/public/js/scripts/helpers/form.error.helper.js
@@ -2,7 +2,9 @@
     // @deprecated, will be removed in 5.0
     ibexa.addConfig('helpers.formError', {
         formatLine: (...args) => {
-            console.warn('helpers.formError.formatLine method is deprecated and will be removed in 5.0');
+            console.warn(
+                'helpers.formError.formatLine method is deprecated and will be removed in 5.0, please use helpers.formValidation.formatErrorLine instead.',
+            );
 
             return ibexa.helpers.formValidation.formatErrorLine(...args);
         },

diff --git a/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js b/src/bundle/Resources/public/js/scripts/helpers/form.validation.helper.js
@@ -1,7 +1,7 @@
 (function (global, doc, ibexa, Translator) {
     const formatErrorLine = (errorMessage) => {
         const errorIcon = `<svg class="ibexa-icon ibexa-icon--small ibexa-form-error__icon">
-            <use xlink:href="${window.ibexa.helpers.icon.getIconPath('warning-triangle')}"></use>
+            <use xlink:href="${ibexa.helpers.icon.getIconPath('warning-triangle')}"></use>
         </svg>`;
         const container = document.createElement('em');
         const errorMessageNode = document.createTextNode(errorMessage);

diff --git a/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig b/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig
@@ -27,6 +27,7 @@
             is_selector: attr.is_selector|default(false),
             is_dynamic: attr.is_dynamic|default(false),
             has_select_all_toggler: attr.has_select_all_toggler|default(false),
+            placeholder: attr.placeholder|default(),
         } %}
     {% endif %}
 {%- endblock choice_widget -%}