-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
The file specified is not available and making webpack complain, so commenting I'm commenting it out for now
and it takes a *long* time
Current coverage is 100%@@ master #4 diff @@
===================================
Files 5 3 -2
Lines 38 12 -26
Methods 0 0
Messages 0 0
Branches 0 0
===================================
- Hits 38 12 -26
Misses 0 0
Partials 0 0
|
So much thank's for the work @JaKXz it works great 👍 I think we can merge this into master? It will need a little rebase but seems good :) |
No worries @iam4x! I wouldn't pull the trigger on merging just yet because I think the wrong files are being covered. This was meant to be more of a demonstration of the right config / what would be expected to work. My other hypothesis is that the babel-webpack-loaders plugin is conflicting with nyc and I haven't had a chance to look closely at how that plugin works (cc @bcoe). Perhaps you can try making all the same changes with the latest versions of nyc and babel-plugin-istanbul and see if things go better? If possible, I'd also suggest using a file structure and naming for tests that plays a little nicer with AVA and nyc. There's a good argument for putting your tests alongside the code you're writing that @kentcdodds put in a nice article. The bonus there is that AVA looks for those |
Thanks for the shoutout @JaKXz. Read that here: http://kcd.im/co-location
Yeah, I have opinions about things and I make pull requests to libraries so my opinions integrate well 😉 |
@JaKXz @iam4x I will happily land any pull requests ASAP, that help move us closer to supporting webpack appropriately... an aside, It's getting to the point that there are enough different: configurations, frameworks, dials, knobs, and testing frameworks that interact with |
@bcoe sounds good to me. |
@iam4x just wanted to make this PR so we can discuss your project-specific (non-nyc) things. I have to say I like your setup and I'm excited to see if we can get webpack and nyc to play nice :)
cc @bcoe