Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom View Overlay fix #3308

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Custom View Overlay fix #3308

merged 4 commits into from
Mar 10, 2022

Conversation

NancyMcCallB
Copy link
Contributor

Custom view overlays do not display in a viewport.

@NancyMcCallB NancyMcCallB requested a review from a team as a code owner March 7, 2022 20:00
@NancyMcCallB
Copy link
Contributor Author

@calebmshafer @williamkbentley Any idea why this PR keeps failing?

@williamkbentley
Copy link
Member

@calebmshafer should we do one of these - #3309 - for release/3.0.0?

@calebmshafer
Copy link
Member

@calebmshafer should we do one of these - #3309 - for release/3.0.0?

@williamkbentley yes, I started it here, #3314. However, haven't had a chance to figure out why it hasn't worked... I think I tried out the build after we fixed those conditions on it but let me try that again to be sure.

@williamkbentley
Copy link
Member

@calebmshafer should we do one of these - #3309 - for release/3.0.0?

@williamkbentley yes, I started it here, #3314. However, haven't had a chance to figure out why it hasn't worked... I think I tried out the build after we fixed those conditions on it but let me try that again to be sure.

I'll work on getting that PR completed. I think I know the error and can fix.

@calebmshafer calebmshafer enabled auto-merge (squash) March 10, 2022 18:21
@calebmshafer calebmshafer merged commit 68f493f into release/3.0.x Mar 10, 2022
@calebmshafer calebmshafer deleted the ui/view-overlay-fix branch March 10, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants