react to breaking change in 3.0 wrt ecsql query row format (backport #3257) #3259
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Co-authored-by: Arun George <[email protected]> (cherry picked from commit d1db893)
mergify
bot
requested review from
a team,
kabentley and
bbastings
as code owners
|
Same comment as from original PR: How was this not caught by tests and should there be a test that would have caught it / will catch future regressions? |
Sorry PR auto merged before I could reply. It wasn't caught due to all the mocking we due, and not testing against an actual iModel connection. Not sure how we'd catch this in the future outside of setting up some e2e to test against an actual iModel connection. @saskliutas any ideas? |
There are some tests that are testing ModelsTree using real iModel. I will try add some for CategoriesTree too. |
I assume this will be in a separate pr? Because it also needs to get backported back to master |
Yes I will open a new PR for test. |
This is an automatic backport of pull request #3257 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com