Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esbuild, koa, and octokit to fix audit #2447

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Bump esbuild, koa, and octokit to fix audit #2447

merged 1 commit into from
Mar 3, 2025

Conversation

r100-stack
Copy link
Member

@r100-stack r100-stack commented Feb 21, 2025

Changes

Fixes audit:

Fixes audit by bumping koa, esbuild, and octokit. Used a pnpm overrides for esbuild since even the latest @vanilla-extract/integration (a subdep in the remix playground) uses an old `esbuild version.

pnpm why esbuild in playgrounds/remix:

devDependencies:
@remix-run/dev 2.16.0
├─┬ @vanilla-extract/integration 6.5.0 👈
│ ├── esbuild 0.17.6
│ ├─┬ vite 6.2.0
│ │ └── esbuild 0.25.0
│ └─┬ vite-node 1.6.1
│   └─┬ vite 6.2.0
│     └── esbuild 0.25.0
├── esbuild 0.17.6
├─┬ esbuild-plugins-node-modules-polyfill 1.6.3
│ └── esbuild 0.17.6 peer
├─┬ vite 6.2.0 peer
│ └── esbuild 0.25.0
└─┬ vite-node 3.0.0-beta.2
  └─┬ vite 6.2.0
    └── esbuild 0.25.0
vite 6.2.0
└── esbuild 0.25.0
vite-tsconfig-paths 5.1.4
└─┬ vite 6.2.0 peer
  └── esbuild 0.25.0

Since we updated octokit by a major version, not sure if will break anything in publish-packages.mjs and thus in the release script and in the CD workflow.

Also, there are some deps that are not at their latest version (e.g. vite, vitest, astro, etc.). Thus, their esbuild version ranges may not include [email protected]. So, the esbuild pnpm overrides applies to them. Thus, added an after-PR TODO to update deps to their latest versions soon. (more info)

Testing

  • Audit passes
  • CI passes

Added an after-PR TODO removing the pnpm override.

Docs

No changeset since it seems to only be related to dev dependencies.

After PR TODO

  • Try removing esbuild pnpm override when @vanilla-extract/integration supports esbuild@>=0.25.0.
  • Update more deps to latest versions. (#2447 (comment))

@r100-stack r100-stack self-assigned this Feb 21, 2025
@r100-stack r100-stack marked this pull request as ready for review February 21, 2025 21:26
@r100-stack r100-stack requested a review from a team as a code owner February 21, 2025 21:26
@r100-stack r100-stack requested review from mayank99 and removed request for a team February 21, 2025 21:26
@r100-stack
Copy link
Member Author

r100-stack commented Mar 3, 2025

Tried to update the packages (e.g. vite and astro) to avoid using the pnpm override. But looks like even the latest version of some other packages don't include the latest esbuild version in their range.

Updated the PR description accordingly.

@r100-stack r100-stack merged commit ebd7f8b into main Mar 3, 2025
18 checks passed
@r100-stack r100-stack deleted the r/audit-7 branch March 3, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants