-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ComboBox filter reset behavior (clearFilterOnOptionToggle
)
#2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple-filter-behavior
smmr-dn
reviewed
Oct 10, 2024
clearFilterOnOptionToggle
)
mayank99
reviewed
Oct 17, 2024
smmr-dn
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have any further comments on this PR at the moment so I'm approving this. I will take a look back when you make changes later.
mayank99
approved these changes
Oct 23, 2024
smmr-dn
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds on to the patch fix in #2295 to completely address #2276.
Added a new
clearFilterOnOptionToggle
prop (name bikesheddable) only whenmultiple
istrue
. Possible values:true
(default): Filter is cleared when an option is toggled. Useful when users would likely want to re-filter after toggling an option.false
: Filter is not cleared when an option is toggled. This is useful when users would likely want to toggle multiple options from the same filtered results.Since the default value is
true
, which is the existing behavior before this PR, there is no change in the default behavior (no breaking change).This prop allows the user to choose the behavior since as we see in #2276, both behaviors have benefits.
Testing
clearFilterOnOptionToggle
.Docs
Added minor changeset.