Workaround for unscrollable sidenav in react-workshop #2283
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r100-stack
requested review from
mayank99 and
smmr-dn
and removed request for
a team
mayank99
reviewed
Oct 4, 2024
Co-authored-by: Mayank <[email protected]>
mayank99
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@mayank99 noticed that the sidenav is not scrollable in newer versions of Chrome (e.g. 129.0, Canary 131). But it works in Edge 128.0, Firefox 130.0, and Safari 16.6.
Ladle already has an issue for this: tajo/ladle#574
Until they investigate why it doesn't work in Chrome and until either we or Ladle do a proper fix, this PR adds custom styles to make the sidenav scrollable. This is important as users using the
react-workshopon Chrome might not be able to see all demos.Testing
The sidenav is now scrollable in Chrome 129.0:
Docs
N/A