-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore old ExpandableBlock
api
#1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExpandableBlock
apiExpandableBlock
api
gretanausedaite
approved these changes
Aug 21, 2023
r100-stack
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having some website examples that still use the old API would be good.
Updated. |
4bcfa7e
to
bf00897
Compare
bf00897
to
3e65703
Compare
r100-stack
reviewed
Aug 22, 2023
Co-authored-by: Rohan Kadkol <[email protected]>
r100-stack
approved these changes
Aug 22, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
undid the breaking change from #1354 and brought back
title
/caption
/endIcon
props while also supporting the new subcomponents added in that PR.renamed
ExpandableBlock.Header
toExpandableBlock.Trigger
as it makes more sense.these two snippets are now equivalent:
Testing
updated one story and added one unit test.
Docs
updated old changeset. updated documentation page.
will update migration guide too.