allow setting icon size and fill from outside #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
gretanausedaite and
LostABike
and removed request for
a team
LostABike
approved these changes
Jun 21, 2023
gretanausedaite
approved these changes
Jun 26, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Restructured the icon css slightly, adding new public-facing
--iui-svg-sizeand--iui-svg-fillvars. These new vars will be preferred over the internal versions (prefixed with _), allowing easier modifications. The benefit of this would be that we wouldn't need to duplicate icon styling in a bunch of components, as we could simply addiui-svg-iconin the html and then specify these css vars inside the component css.Testing
All* existing usage is unchanged. Setting size and fill from outside is reflected correctly.
*had to change expandable-block.html to add missing class.
Docs
added changeset.