set color-scheme based on current theme
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
gretanausedaite,
adamhock and
FlyersPh9
and removed request for
a team
FlyersPh9
approved these changes
Jun 15, 2023
gretanausedaite
approved these changes
Jun 16, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
color-schemeproperty to match the current theme. Default value of this property islight, so it will have a real impact only on dark theme. Also added adaptivelight darkas a fallback when no theme is set.Testing
A bit hard to really test because our components are already themed, but can be noticed in native UI elements, like this autofill background:
Docs
added changeset.